[cfe-commits] [PATCH] [PR 12026] Restore target-prefix tool support

[Chandler Carruth]

On Mon, Feb 20, 2012 at 8:39 AM, Joerg Sonnenberger <joerg at britannica.bec.de
> wrote:

> Hi all,
> this is the minimally intrusive fix for the target-prefixed toolchain
> support. This is a partial revert of r148839, fixed in r149083, reverted
> and re-broken in r149337. Given that's been 3 weeks now with a proper
> solution, I think it is time to restore the status quo. See also PR
> 12026.
>

This is a hack though, and it's important to acknowledge that. We're now
handling -target in two separate places. It would be better to sink this
down to be grouped with the 'getToolChain()' call that is relevant, and add
comments at the very least.

Also, to introduce a hack like this, we definitely need good test cases so
that we understand what is and isn't supposed to work. Relying on the
happenstance of DefaultTargetTriple is what got us into the mess in the
first place.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120220/0be16120/attachment.html>