[cfe-commits] r150905 - /cfe/trunk/test/Driver/gcc-toolchain.cpp

[Chad Rosier]

Hi Rafael,
We're still seeing failures for this test on our internal buildbots.

On Feb 18, 2012, at 6:23 PM, Rafael Espindola wrote:

> Author: rafael
> Date: Sat Feb 18 20:23:50 2012
> New Revision: 150905
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=150905&view=rev
> Log:
> Add an extra CHECK line to make sure TOOLCHAIN2 matches just the path
> prefix.
> 
> Modified:
>    cfe/trunk/test/Driver/gcc-toolchain.cpp
> 
> Modified: cfe/trunk/test/Driver/gcc-toolchain.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/gcc-toolchain.cpp?rev=150905&r1=150904&r2=150905&view=diff
> ==============================================================================
> --- cfe/trunk/test/Driver/gcc-toolchain.cpp (original)
> +++ cfe/trunk/test/Driver/gcc-toolchain.cpp Sat Feb 18 20:23:50 2012
> @@ -19,7 +19,8 @@
> // CHECK: "/include"
> // CHECK: "-internal-externc-isystem"
> // CHECK: "/usr/include"
> -// CHECK: "{{.*}}/ld
> +// CHECK: "{{.*}}/ld{{(.exe)?}}"

The test is failing to match due to the / before ld.  Would this test case still behave as expected if it were: 

// CHECK: "{{.*}}ld{{(.exe)?}}"

I've seen similar in other tests (i.e., darwin-ld.c) and I believe it would make our builders happy.

 Chad

> +// CHECK: "crti.o"
> // CHECK: "[[TOOLCHAIN2:.*]]/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5/crtbegin.o"
> // CHECK: "-L[[TOOLCHAIN2]]/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5"
> // CHECK: "-L[[TOOLCHAIN2]]/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5/../../../.."
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits