[cfe-commits] [PATCH 4/5] [clang.py] Add tests for Type.is_volatile_qualified and Type.is_restrict_qualified

Gregory Szorc gregory.szorc at gmail.com
Sat Feb 18 20:29:37 PST 2012


Feedback incorporated. Also, the comment in my previous email about
changing the get_cursor() implementation really applies to this patch.

On Fri, Feb 17, 2012 at 4:43 AM, Manuel Klimek <klimek at google.com> wrote:

> +    i, j = None, None
> +    for cursor in tu.cursor.get_children():
> +        if cursor.spelling == 'i':
> +            i = cursor
> +        elif cursor.spelling == 'j':
> +            j = cursor
>
> I'd reuse get_cursor from patch 2 here.
>
> Cheers,
> /Manuel
>
> On Fri, Feb 17, 2012 at 8:58 AM, Gregory Szorc <gregory.szorc at gmail.com>
> wrote:
> > ---
> >  bindings/python/tests/cindex/test_type.py |   39
> +++++++++++++++++++++++++++++
> >  1 files changed, 39 insertions(+), 0 deletions(-)
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120218/a2ef4369/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-clang.py-Add-tests-for-Type.is_volatile_qualified-an.patch
Type: application/octet-stream
Size: 2853 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120218/a2ef4369/attachment.obj>


More information about the cfe-commits mailing list