[cfe-commits] [PATCH 3/5] [clang.py] Implement Type.arguments()

Gregory Szorc gregory.szorc at gmail.com
Sat Feb 18 20:28:30 PST 2012


I've refactored existing tests to use the new get_cursor(). I also changed
the implementation of get_cursor to support recursion. In a forthcoming
patch, I have added an argument to get_children() to recurse. Until then,
this suboptimal implementation can persist.

On Fri, Feb 17, 2012 at 4:39 AM, Manuel Klimek <klimek at google.com> wrote:

> Regarding the introduction of get_cursor(...): same as in the other
> patch: looks like a good idea, but then use that in the other tests,
> too. Also, like in the other patch, I'm still confused whether there's
> a scheme behind when you use ok_ and when you use assert...
>
> In general: very nice tests :)
>
> Cheers,
> /Manuel
>
> On Fri, Feb 17, 2012 at 8:57 AM, Gregory Szorc <gregory.szorc at gmail.com>
> wrote:
> > I incorporated feedback from Tobias and exposed arguments as an
> > iterable and indexable container object.
> >
> > ---
> >  bindings/python/clang/cindex.py           |   47 +++++++++++++++++++
> >  bindings/python/tests/cindex/test_type.py |   69
> +++++++++++++++++++++++++++++
> >  2 files changed, 116 insertions(+), 0 deletions(-)
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120218/6da08e35/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-clang.py-Implement-Type.arguments.patch
Type: application/octet-stream
Size: 14247 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120218/6da08e35/attachment.obj>


More information about the cfe-commits mailing list