[cfe-commits] r150797 - /cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Douglas Gregor dgregor at apple.com
Fri Feb 17 08:45:07 PST 2012


On Feb 16, 2012, at 11:09 PM, Eric Christopher wrote:

> Author: echristo
> Date: Fri Feb 17 01:09:48 2012
> New Revision: 150797
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=150797&view=rev
> Log:
> Index "12" holds the vtable, not "9".

Doesn't this just scream "named constant"?

	- Doug

> Fixes lots of gdb testsuite failures.
> 
> Modified:
>    cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
> 
> Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=150797&r1=150796&r2=150797&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Fri Feb 17 01:09:48 2012
> @@ -1798,7 +1798,7 @@
>     else if (CXXDecl->isDynamicClass())
>       ContainingType = RealDecl;
> 
> -    RealDecl->replaceOperandWith(9, ContainingType);
> +    RealDecl->replaceOperandWith(12, ContainingType);
>   }
>   return llvm::DIType(RealDecl);
> }
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list