[cfe-commits] [PATCH 1/5] [clang.py] Implement Type.is_function_variadic

[Manuel Klimek]

Hi Gregory,

in test_type.py: use the new get_tu function in the other tests around
the new one, too? (otherwise why pull out a function)

+    ok_(isinstance(foo.type.is_function_variadic(), bool))
This seems a non-pythonic test to me - why do we care about the
underlying type of the result as long as it evaluates to True / False
in bool context correctly?

Generally, why use ok_ when all the tests around use normal assert?

Cheers,
/Manuel

On Fri, Feb 17, 2012 at 8:56 AM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> I have commit access now, so I just need review. The two commits I
> just pushed to SVN were approved by Tobias a few weeks ago.
>
> ---
>  bindings/python/clang/cindex.py           |   10 ++++++++
>  bindings/python/tests/cindex/test_type.py |   33 +++++++++++++++++++++++++++++
>  2 files changed, 43 insertions(+), 0 deletions(-)
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>