[cfe-commits] r150711 - /cfe/trunk/include/clang/Analysis/Analyses/FormatString.h

Ted Kremenek kremenek at apple.com
Thu Feb 16 10:42:28 PST 2012


Ok, that's totally unclear from the comment.  The comment in the code is context-free from the original email thread.  Can you please enhance the comment to reference the appropriate section in the standard?

Thanks,
Ted

On Feb 16, 2012, at 10:32 AM, Hans Wennborg <hans at chromium.org> wrote:

> On Thu, Feb 16, 2012 at 18:27, Ted Kremenek <kremenek at apple.com> wrote:
>> 
>> On Feb 16, 2012, at 10:19 AM, Hans Wennborg <hans at hanshq.net> wrote:
>> 
>> +    AsQuad,       // 'q' (BSD, deprecated, same as PRI?64)
>> 
>> 
>> Special character in the comment?  The PR # looks wrong.
> 
> It's not a PR number, it's referring to the PRIo64 / PRIu64 / ...
> macro for format specifiers (C99 7.8.1), that Joerg suggested in his
> reply to my original commit.
> 
> - Hans




More information about the cfe-commits mailing list