[cfe-commits] [Patch] New warning for scopes that start in one file and end in another.

Eli Friedman eli.friedman at gmail.com
Wed Feb 15 20:47:16 PST 2012


On Wed, Feb 15, 2012 at 8:30 PM, Richard Trieu <rtrieu at google.com> wrote:
> On Wed, Feb 15, 2012 at 8:27 PM, Eli Friedman <eli.friedman at gmail.com>
> wrote:
>>
>> On Wed, Feb 15, 2012 at 8:22 PM, Richard Trieu <rtrieu at google.com> wrote:
>> > This patch contains a new warning that will identify scopes that start
>> > in
>> > one file and ends in another.  It does so by checking the location of
>> > the
>> > closing brace against the location of the opening brace.  Macros are
>> > ignored.
>>
>> Missing patch.
>>
>> -Eli
>
>
> Silly me.  Thanks.

Mechanically, the patch looks fine...

What sort of testing have you done with this patch?  Has this caught
any interesting issues in existing code?  If not, why is this warning
useful?  Any false positives we should be aware of?

-Eli




More information about the cfe-commits mailing list