[cfe-commits] [patch] Make it so that some warnings in DiagGroup<"all"> aren't on by default

[David Blaikie]

I know we chatted about this before & agreed (& I think Eli did too)
it made sense - when I brought this up again on IRC to get signoff for
the change (I was just going to blanket change all the -Wall warnings
that weren't also in -Wmost to DefaultIgnore) Chandler and Tronic (not
sure of real/committer name) objected a bit, so I killed off my work
in that area. Perhaps they'll have something to contribute on the
record here.

On Tue, Feb 14, 2012 at 6:43 PM, Nico Weber <thakis at chromium.org> wrote:
> Now with many percent more patch attached.
>
> On Tue, Feb 14, 2012 at 6:28 PM, Nico Weber <thakis at chromium.org> wrote:
>> Hi,
>>
>> -Wall is defined like this:
>>
>>  def : DiagGroup<"all", [Most, Parentheses, Switch]>;
>>
>> This makes sense, but _all_ of the warnings in Parentheses and Switch
>> are on by default, so -Wall is currently identical to -Wmost. With
>> this patch, some of the warnings in that group become DefaultIgnore,
>> so that they are only active if -Wall is specified. It looks like that
>> was the intention for most of them, but since DiagGroup<"all"> is a
>> bit confusing in this regard, they got always-enabled by accident (as
>> far as I can tell).
>>
>> Ok?
>>
>> Nico
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>