[cfe-commits] PATCH: Add -Wreturn-type-c-linkage

[Ted Kremenek]

On Feb 13, 2012, at 2:02 PM, Aaron Ballman <aaron at aaronballman.com> wrote:

> On Mon, Feb 13, 2012 at 3:55 PM, Matt Beaumont-Gay <matthewbg at google.com> wrote:
>> The new "your 'extern "C" function is returning a non-POD type'"
>> warning fires on a lot of code which we would like to continue
>> building with -Werror=return-type. This patch gives the new warning
>> its own flag so it can be selectively disabled.
> 
> Patch LGTM, but before I commit, I'm wondering if there's any argument
> against having it in its own group?

I think it is fine for the warning to have its own group.  It seems like there is a reasonable case where someone would want to selectively disable this warning.