[cfe-commits] [PATCH] Illegal qualifiers not caught properly

[Richard Smith]

r150244.

On Fri, Feb 10, 2012 at 2:48 AM, Richard Smith <richard at metafoo.co.uk>wrote:

> I've been working on this independently and am about to check in a fix.
> Apologies for the duplicated effort!
>
>
> On Thu, Feb 9, 2012 at 7:40 PM, Aaron Ballman <aaron at aaronballman.com>wrote:
>
>> On Thu, Feb 9, 2012 at 8:44 PM, Eli Friedman <eli.friedman at gmail.com>
>> wrote:
>> > On Thu, Feb 9, 2012 at 6:24 PM, Aaron Ballman <aaron at aaronballman.com>
>> wrote:
>> >> This patch addresses bug 11684 where illegal function qualifiers are
>> >> not caught properly when declaring a function pointer or reference
>> >> inside of a class.  For instance:
>> >>
>> >> struct test {
>> >>  void (*ref)() const;
>> >> };
>> >>
>> >> I mostly reused existing logic to cover the case.  I've also included
>> >> some test cases to exercise the fix.
>> >
>> > We shouldn't allowing forming the type "pointer to const-qualified
>> > function" in the first place... tracking down all the places we use a
>> > type is completely ridiculous.
>>
>> That's fair -- I'll look into taking care of it at the declaration site.
>>
>> Thanks!
>>
>> ~Aaron
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120210/7e1129fb/attachment.html>