[cfe-commits] [PATCH] Strftime and "non literal format"

Jean-Daniel Dupas devlists at shadowlab.org
Tue Feb 7 15:15:20 PST 2012


Thanks. commited as r150009

Le 7 févr. 2012 à 20:32, Ted Kremenek a écrit :

> Looks reasonable to me.
> 
> On Feb 2, 2012, at 1:28 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:
> 
>> Hi,
>> 
>> I'm wondering if it is right to emit warnings when using a non literal string in strftime function.
>> Unlike other format functions, this one takes only 1 single mandatory argument that represents the time we want to format.
>> So, unlike other format functions, it should not be 'unsafe' to pass an arbitrary string.
>> 
>> Here is a patch that disable this warning for strftime format.
>> 
>> What do you think about it ? 
>> 
>> Thanks
>> 
>> -- Jean-Daniel
>> 
>> 
>> 
>> <strftime.patch>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- Jean-Daniel








More information about the cfe-commits mailing list