[cfe-commits] r149657 - in /cfe/trunk: lib/Sema/SemaChecking.cpp test/Sema/warn-strncat-size.c

[Anna Zaks]

Author: zaks
Date: Thu Feb  2 19:27:37 2012
New Revision: 149657

URL: http://llvm.org/viewvc/llvm-project?rev=149657&view=rev
Log:
Do not show macro expansion in strncat warnings, which can be defined as
a builtin.

Modified:
    cfe/trunk/lib/Sema/SemaChecking.cpp
    cfe/trunk/test/Sema/warn-strncat-size.c

Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=149657&r1=149656&r2=149657&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaChecking.cpp (original)
+++ cfe/trunk/lib/Sema/SemaChecking.cpp Thu Feb  2 19:27:37 2012
@@ -2742,12 +2742,22 @@
   if (PatternType == 0)
     return;
 
+  // Generate the diagnostic.
+  SourceLocation SL = LenArg->getLocStart();
+  SourceRange SR = LenArg->getSourceRange();
+  SourceManager &SM  = PP.getSourceManager();
+
+  // If the function is defined as a builtin macro, do not show macro expansion.
+  if (SM.isMacroArgExpansion(SL)) {
+    SL = SM.getSpellingLoc(SL);
+    SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
+                     SM.getSpellingLoc(SR.getEnd()));
+  }
+
   if (PatternType == 1)
-    Diag(DstArg->getLocStart(), diag::warn_strncat_large_size)
-      << LenArg->getSourceRange();
+    Diag(SL, diag::warn_strncat_large_size) << SR;
   else
-    Diag(DstArg->getLocStart(), diag::warn_strncat_src_size)
-      << LenArg->getSourceRange();
+    Diag(SL, diag::warn_strncat_src_size) << SR;
 
   // Output a FIXIT hint if the destination is an array (rather than a
   // pointer to an array).  This could be enhanced to handle some
@@ -2773,9 +2783,8 @@
   DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
   OS << ") - 1";
 
-  Diag(LenArg->getLocStart(), diag::note_strncat_wrong_size)
-    << FixItHint::CreateReplacement(LenArg->getSourceRange(),
-                                    OS.str());
+  Diag(SL, diag::note_strncat_wrong_size)
+    << FixItHint::CreateReplacement(SR, OS.str());
 }
 
 //===--- CHECK: Return Address of Stack Variable --------------------------===//

Modified: cfe/trunk/test/Sema/warn-strncat-size.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-strncat-size.c?rev=149657&r1=149656&r2=149657&view=diff
==============================================================================
--- cfe/trunk/test/Sema/warn-strncat-size.c (original)
+++ cfe/trunk/test/Sema/warn-strncat-size.c Thu Feb  2 19:27:37 2012
@@ -1,9 +1,20 @@
 // RUN: %clang_cc1 -Wstrncat-size -verify -fsyntax-only %s
+// RUN: %clang_cc1 -DUSE_BUILTINS -Wstrncat-size -verify -fsyntax-only %s
+// RUN: %clang_cc1 -fsyntax-only -Wstrncat-size -fixit -x c %s
+// RUN: %clang_cc1 -DUSE_BUILTINS -fsyntax-only -Wstrncat-size -fixit -x c %s
 
 typedef __SIZE_TYPE__ size_t;
-char  *strncat(char *, const char *, size_t);
 size_t strlen (const char *s);
 
+#ifdef USE_BUILTINS
+# define BUILTIN(f) __builtin_ ## f
+#else
+# define BUILTIN(f) f
+#endif
+
+#define strncat BUILTIN(strncat)
+char *strncat(char *restrict s1, const char *restrict s2, size_t n);
+
 struct {
   char f1[100];
   char f2[100][3];