[cfe-commits] r149587 - in /cfe/trunk: lib/AST/ASTContext.cpp test/CodeGen/inline.c test/CodeGen/inline2.c

Eli Friedman eli.friedman at gmail.com
Thu Feb 2 14:34:41 PST 2012


On Wed, Feb 1, 2012 at 9:33 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Wed, Feb 1, 2012 at 9:13 PM, Anton Yartsev <anton.yartsev at gmail.com> wrote:
>> Author: ayartsev
>> Date: Wed Feb  1 23:13:59 2012
>> New Revision: 149587
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=149587&view=rev
>> Log:
>> Fix for PR10657 (http://llvm.org/bugs/show_bug.cgi?id=10657)
>> extern inline case considered
>>
>> Modified:
>>    cfe/trunk/lib/AST/ASTContext.cpp
>>    cfe/trunk/test/CodeGen/inline.c
>>    cfe/trunk/test/CodeGen/inline2.c
>
> The changes you are making to the tests are clearly wrong.  Please
> revert, and we can discuss the correct way to fix your testcase.

I just took a quick look; a correct patch would probably involve
changing FunctionDecl::doesDeclarationForceExternallyVisibleDefinition
.

-Eli




More information about the cfe-commits mailing list