[cfe-commits] [patch] Remove most of the --with-cxx-* logic

[Sebastian Pop]

2012/2/2 Rafael Espíndola <rafael.espindola at gmail.com>:
>> I like this name better, if at least it was also pointing to the top
>> dir of the gcc install, as this name implies...  Is there a reason we
>> need to point to the subdir that contains the libstdc++ include files
>> instead of pointing to the top dir of the toolchain?
>
> We don't need to point to the inner directory, and this patch changes
> that. We used to just because it was easier in the days we had no
> central logic for understanding a gcc installation layout.
>
>> So we want clang to use a gcc based toolchain, then why don't we call
>> it --with-gcc-toolchain?
>
> I like the idea of having "prefix" in the name to match the "--prefix"
> option used when building gcc.

I like this idea!  Thanks for the cleanup as well,
the code looks very nice after your changes :-).

+# With this option, clang will use the provided gcc installation instead of the
+# system one. This should be passed the same value that was used with --prefix
+# when configuring gcc.
+AC_ARG_WITH(gcc-install-prefix,
+  AS_HELP_STRING([--with-gcc-install-prefix],
+    [Directory where gcc is installed.]),,

Why not using just --with-gcc-prefix?

Or even better --with-gcc.  That would be compatible with what
other configures are doing when using external packages.

If we go this road, we should document the meaning of this configure flag,
as people could get confused in between the gcc used to compile llvm,
and the toolchain used for the target (what we want here).  That's why I
still think that --with-gcc-toolchain was better.  Or,...
what about --with-target-gcc?

Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum