[cfe-commits] [patch][pr11822] Error on mismatched #pragma GCC visibility push/pop

[Richard Smith]

2012/1/31 Rafael Espíndola <rafael.espindola at gmail.com>

> > I think we could be more explicit that the problem is caused by the
> > namespace having a visibility attribute. Possible wording for the three
> > cases:
> >
> > error: #pragma visibility push with no matching #pragma visibility pop
> > note: surrounding namespace with visibility attribute ends here
> >
> > error: #pragma visibility pop with no matching #pragma visibility push
> > note: surrounding namespace with visibility attribute starts here
> >
> > error: #pragma visibility pop with no matching #pragma visibility push
>
> Make sense. Updated patch attached.
>

Thanks! Given the updated wording, the namspace start/end notes should have
more specific names. With that, LGTM.

Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120131/3fe9e6a3/attachment.html>