[cfe-commits] [patch] Remove most of the --with-cxx-* logic

[Sebastian Pop]

2012/1/31 Chandler Carruth <chandlerc at google.com>:
> 'with-cxx-install-root' is the flag, and the docs then talk about
> 'libstdc++'. This made me want to rename the flag
> 'with-libstdcxx-install-root' at first,

I like the original flag name --with-cxx-include-dir as it conveys the
meaning of the dir that has the libstdc++ include files.

> but then I looked at how you used
> it. You're just providing a root to look for the GCC installation in, not a
> root for libstdc++. This root will impact what linker is invoke, what
> assembler (if one is needed), etc. That makes me think it should be
> 'with-gcc-install-root'.

I like this name better, if at least it was also pointing to the top
dir of the gcc install, as this name implies...  Is there a reason we
need to point to the subdir that contains the libstdc++ include files
instead of pointing to the top dir of the toolchain?

So we want clang to use a gcc based toolchain, then why don't we call
it --with-gcc-toolchain?

Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum