[cfe-commits] r149258 - in /cfe/trunk: lib/StaticAnalyzer/Checkers/Checkers.td test/Analysis/CFContainers.mm

Ted Kremenek kremenek at apple.com
Mon Jan 30 11:55:21 PST 2012


I don't think we need to keep the word "Syntax" in the checker name.  That's fine as an implementation detail, but users shouldn't have to care how it is implemented.

On Jan 30, 2012, at 11:12 AM, Anna Zaks wrote:

> Author: zaks
> Date: Mon Jan 30 13:12:37 2012
> New Revision: 149258
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=149258&view=rev
> Log:
> [analyzer] Make osx.cocos.CFContainersSyntax a default checker.
> 
> Modified:
>    cfe/trunk/lib/StaticAnalyzer/Checkers/Checkers.td
>    cfe/trunk/test/Analysis/CFContainers.mm
> 
> Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/Checkers.td
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/Checkers.td?rev=149258&r1=149257&r2=149258&view=diff
> ==============================================================================
> --- cfe/trunk/lib/StaticAnalyzer/Checkers/Checkers.td (original)
> +++ cfe/trunk/lib/StaticAnalyzer/Checkers/Checkers.td Mon Jan 30 13:12:37 2012
> @@ -364,14 +364,14 @@
>   HelpText<"Check for leaks and improper reference count management">,
>   DescFile<"RetainCountChecker.cpp">;
> 
> +def ObjCContainersASTChecker : Checker<"CFContainersSyntax">,
> +  HelpText<"Check for common pitfalls when using 'CFArray', 'CFDictionary', 'CFSet' APIs">,
> +  DescFile<"ObjCContainersASTChecker.cpp">;  
> +
> } // end "cocoa"
> 
> let ParentPackage = CocoaExperimental in {
> 
> -def ObjCContainersASTChecker : Checker<"ContainerAPI">,
> -  HelpText<"Check for common pitfalls when using 'CFArray', 'CFDictionary', 'CFSet' APIs">,
> -  DescFile<"ObjCContainersASTChecker.cpp">;
> -
> def ObjCContainersChecker : Checker<"Containers">,
>   HelpText<"Deep checks for common pitfalls when using 'CFArray' APIs">,
>   DescFile<"ObjCContainersChecker.cpp">;
> 
> Modified: cfe/trunk/test/Analysis/CFContainers.mm
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/CFContainers.mm?rev=149258&r1=149257&r2=149258&view=diff
> ==============================================================================
> --- cfe/trunk/test/Analysis/CFContainers.mm (original)
> +++ cfe/trunk/test/Analysis/CFContainers.mm Mon Jan 30 13:12:37 2012
> @@ -1,4 +1,4 @@
> -// RUN: %clang_cc1 -analyze -analyzer-checker=experimental.osx.cocoa.ContainerAPI,experimental.osx.cocoa.Containers -analyzer-store=region -triple x86_64-apple-darwin -verify %s
> +// RUN: %clang_cc1 -analyze -analyzer-checker=osx.cocoa.CFContainersSyntax,experimental.osx.cocoa.Containers -analyzer-store=region -triple x86_64-apple-darwin -verify %s
> 
> typedef const struct __CFAllocator * CFAllocatorRef;
> typedef const struct __CFString * CFStringRef;
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list