[cfe-commits] [patch][pr11822] Error on mismatched #pragma GCC visibility push/pop

Chandler Carruth chandlerc at google.com
Sun Jan 29 22:03:09 PST 2012

On Sun, Jan 29, 2012 at 9:44 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> Chandler, some word smithing on the errors would be appreciated.

Is it possible to error on the #prama, even when diagnosing the case about
the namespace end? That would be ideal...

If not possible (and I can see reasons why it may not be) I would reverse
the wording in the message:

"namespace ends inside a still-open pragma visibility"

I'm not entirely happy with the error message, as reading the errors I
don't actually know what's gone wrong. ;] However, I don't know whats gone
wrong reading the code either, so I'm hoping Richard can suggest more
descriptive messages?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120129/2f8be7e0/attachment.html>

More information about the cfe-commits mailing list