[cfe-commits] [PATCH] format attribute improvements.

[Fariborz Jahanian]

On Jan 28, 2012, at 3:11 PM, Jean-Daniel Dupas wrote:

> 
> Le 26 janv. 2012 à 18:49, Jean-Daniel Dupas a écrit :
> 
>> 
>> Le 26 janv. 2012 à 18:38, jahanian a écrit :
>> 
>>> 
>>> On Jan 26, 2012, at 1:45 AM, Jean-Daniel Dupas wrote:
>>> 
>>>> 
>>>> Le 25 janv. 2012 à 22:02, jahanian a écrit :
>>>> 
>>> 
>>> I see. Patch is OK. However, there may be concern about performance of passing a StringRef down. Can you instead pass an
>>> enum value of routine names you are interested in?
>>> 
>>> - Fariborz
>> 
>> 
>> OK. I will have a look at it.
> 
> Here is a new patch that use an enum instead of the StringRef. Does it match what you where thinking about ?

Looks good to me. Thanks.

> 
> I have a question though. What are the pro and cons of the llvm::StringSwitch ? When is it better to use it, and when is it better to keep using if/elseif ?

Hope some one would answer that. Interesting question.

- Fariborz

> 
> 
> -- Jean-Daniel
> 
> <1-type.patch>