[cfe-commits] r149184 - in /cfe/trunk: lib/CodeGen/CGObjC.cpp lib/CodeGen/CGObjCMac.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenObjC/arc.m

[Fariborz Jahanian]

On Jan 28, 2012, at 3:10 PM, John McCall wrote:

> On Jan 28, 2012, at 10:46 AM, Fariborz Jahanian wrote:
>> Author: fjahanian
>> Date: Sat Jan 28 12:46:31 2012
>> New Revision: 149184
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=149184&view=rev
>> Log:
>> objc-arc: Perform null check on receiver before sending methods which
>> consume one or more of their arguments. If not done, this will cause a leak
>> as method will not consume the argument when receiver is null.
>> // rdar://10444474
> 
> This patch is completely skipping the emission of arguments if the receiver
> is null, which is not the semantics we want.  Please revert, and we can talk
> about it on Monday.

I agree. This occurred to me after the patch went in.  Only those with side-effetct matter though.

- Fariborz

> 
> John.