[cfe-commits] PATCH: In CorrectTypo, use the cached correction as a starting point instead. (issue 5570046)

Kaelyn Uhrain rikka at google.com
Mon Jan 23 12:49:25 PST 2012

Please ignore this review request. I screwed up the patch upload AND the
description (after returning from lunch, I'd forgotten I hadn't submitted
the changes I meant to have reviewed to my local git repo yet).


On Mon, Jan 23, 2012 at 12:39 PM, <rikka at google.com> wrote:

> Reviewers: kyrtzidis_apple.com,
> Description:
> Previously, for unqualified lookups, a positive cache hit is used as the
> only non-keyword correction and a negative cache hit immediately returns
> an empty TypoCorrection. With the new callback objects, this behavior
> causes false negatives by not accounting for the fact that callback
> objects alter the set of potential/allowed corrections. The new behavior
> is to seed the set of corrections with the cached correction (for
> positive hits) to estabilishing a baseline edit distance. Negative cache
> hits are only stored or used when either no callback object is provided
> or when it returns true for a call to ValidateCandidate with an empty
> TypoCorrection (i.e. when ValidateCandidate does not seem to be doing
> any checking of the TypoCorrection, such as when an instance of the base
> callback class is used solely to specify the set of keywords to be
> accepted).
> Please review this at http://codereview.appspot.com/**5570046/<http://codereview.appspot.com/5570046/>
> Affected files:
>  M include/clang/Parse/Parser.h
>  M include/clang/Sema/Sema.h
>  M lib/Parse/ParseExpr.cpp
>  M lib/Parse/ParseExprCXX.cpp
>  M lib/Sema/SemaExpr.cpp
>  M lib/Sema/SemaLookup.cpp
>  M test/SemaCXX/typo-correction.**cpp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120123/2c1330a5/attachment.html>

More information about the cfe-commits mailing list