[cfe-commits] [Review] Partial fix for PR 11645: put destructor calls before a return statement.

Chandler Carruth chandlerc at google.com
Mon Jan 23 09:24:41 PST 2012

On Mon, Jan 23, 2012 at 5:44 AM, Erik Verbruggen <erik.verbruggen at me.com>wrote:

> So that comes down to one block with destructors for every scope. What
> would be the benefit for that compared to one block for a return that holds
> all destructors?

It makes it a bit easier to inject early exit CFG edges without splitting
blocks. One block isn't going to cut it as not all destructors will always
fire. That said, thinking about it the second time around I can imagine an
easy way to build the CFG with a minimal number of blocks containing
destructors, so maybe its not a big deal either way....
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120123/4966bcd8/attachment.html>

More information about the cfe-commits mailing list