[cfe-commits] r148704 - in /cfe/trunk: lib/Frontend/DiagnosticRenderer.cpp lib/Lex/Lexer.cpp unittests/Lex/LexerTest.cpp

Chandler Carruth chandlerc at google.com
Mon Jan 23 09:27:52 PST 2012

On Mon, Jan 23, 2012 at 8:58 AM, Argyrios Kyrtzidis <akyrtzi at gmail.com>wrote:

> Improve Lexer::getImmediateMacroName to take into account inner macros
> of macro arguments.
> For "MAC1( MAC2(foo) )" and location of 'foo' token it would return
> "MAC1" instead of "MAC2".

This comment, and the comment on the static helper in the
DiagnosticRenderer are at odds... which one is it that returns MAC2 and
which one MAC1?

It would be good (i think) to call only one of them "immediate", the one
returning MAC2.

Does this impact diagnostic output in any way? If so could you include a
testcase that demonstrates that impact?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120123/556f1fcf/attachment.html>

More information about the cfe-commits mailing list