[cfe-commits] [patch][PR11797] Call ActOnFinishNamespaceDef before consumeClose

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Jan 20 23:03:30 PST 2012


On 20/01/12 12:40 AM, Richard Smith wrote:
> Perhaps it's time to review the handling of #pragma visibility. The existing
> mechanism is very flaky -- this is the second subtle bug we've had with it in
> recent months (the previous bug, which probably can still be observed in some
> cases, is that lookahead / tentative parsing which looks past such a #pragma
> applies its effects immediately).

The attached patch implements your suggestion. It also fixes some old
FIXMEs in pragma-visibility.cpp.

Cheers,
Rafael
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pr11797.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120121/8792ed1a/attachment.ksh>


More information about the cfe-commits mailing list