[cfe-commits] cfe-commits Digest, Vol 55, Issue 164

[Anton Lokhmotov]

Hi Tanya,

> +    }
> +    else if (resultType->isExtVectorType()) {

Eli has also noticed that 'else if' should have been on the previous line.

> +      // Handle vector types.
> +      // Vector logical not returns the signed variant of the operand
> type.

The first comment line is not superfluous.

Could you please also add the test below?

Many thanks,
Anton.


diff --git a/test/CodeGenOpenCL/vector_logops.cl
b/test/CodeGenOpenCL/vector_logops.cl
new file mode 100644
index 0000000..35425bd
--- /dev/null
+++ b/test/CodeGenOpenCL/vector_logops.cl
@@ -0,0 +1,19 @@
+// RUN: %clang_cc1 -O3 %s -emit-llvm -o - | FileCheck %s
+
+typedef int int2 __attribute((ext_vector_type(2)));
+
+int test1()
+{
+  int2 a = (int2)(1,0);
+  int2 b = (int2)(1,1);
+  return (a&&b).x + (a||b).y;
+  // CHECK: ret i32 -2
+}
+
+int test2()
+{
+  int2 a = (int2)(1,0);
+  return (!a).y;
+  // CHECK: ret i32 -1
+}
+