[cfe-commits] r148292 - in /cfe/trunk: include/clang/Sema/ lib/AST/ lib/Basic/ lib/Lex/ lib/Parse/ lib/Rewrite/ lib/Sema/ lib/Serialization/ lib/StaticAnalyzer/Checkers/ tools/libclang/ utils/TableGen/

[David Blaikie]

On Mon, Jan 16, 2012 at 11:14 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Mon, Jan 16, 2012 at 10:56 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCodeComplete.cpp?rev=148292&r1=148291&r2=148292&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Sema/SemaCodeComplete.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaCodeComplete.cpp Tue Jan 17 00:56:22 2012
>> @@ -596,8 +596,7 @@
>>       default:
>>         return STC_Arithmetic;
>>     }
>> -    return STC_Other;
>> -
>> +
>>   case Type::Complex:
>>     return STC_Arithmetic;
>>
>> @@ -1370,8 +1369,8 @@
>>   case Sema::PCC_ForInit:
>>     return LangOpts.CPlusPlus || LangOpts.ObjC1 || LangOpts.C99;
>>   }
>> -
>> -  return false;
>> +
>> +  llvm_unreachable("Invalid ParserCompletionContext!");
>>  }
>>
>>  static PrintingPolicy getCompletionPrintingPolicy(const ASTContext
>> &Context,
>> @@ -2793,7 +2792,7 @@
>>     case Decl::ObjCCategory:       return CXCursor_ObjCCategoryDecl;
>>     case Decl::ObjCCategoryImpl:   return CXCursor_ObjCCategoryImplDecl;
>>       // FIXME
>> -      return CXCursor_UnexposedDecl;
>> +      // return CXCursor_UnexposedDecl;
>
>
>
> Based on the lines before this I don't think this is the right fix... The
> FIXME was that we represented ObjCCategory and ObjCCategoryImpl as
> UnexposedDecl; now that we don't it should just be deleted rather than
> commented out?

Ah, thanks - so it was (
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCodeComplete.cpp?r1=146679&r2=147299&pathrev=148292&diff_format=h
)

Committed removal of the comments in r148294

- David