[cfe-commits] r148142 - in /cfe/trunk: include/clang/AST/Decl.h include/clang/Sema/Sema.h lib/AST/Decl.cpp lib/Sema/SemaChecking.cpp

Chris Lattner clattner at apple.com
Sun Jan 15 22:44:37 PST 2012


On Jan 14, 2012, at 9:16 AM, Anna Zaks wrote:

>> 
>> Hi Anna,
>> 
>> Is there a reason not to just use Builtin ID's directly?  Why have another enum?
>> 
> 
> Good point. 
> The reason for the new enum is that it provides better readability: documents what the method handles; and in all the places where the value is used, makes it obvious that it's not just a single builtin. 
> On the other hand, it's probably more undesirable to grow FunctionDecl.. I'll patch to use the built-in ID.

Thanks Anna!

-Chris



More information about the cfe-commits mailing list