[cfe-commits] r143596 - /cfe/trunk/lib/CodeGen/TargetInfo.cpp

[Hatanaka, Akira]

Please see the attached patch. Padding is allowed for any Direct ABIArgInfos.
I removed the assertion in getPaddingType() that ensures the ArgInfo is Direct so that there are fewer changes being made, but I can restore it if necessary.

________________________________________
From: Eli Friedman [eli.friedman at gmail.com]
Sent: Thursday, January 05, 2012 4:23 PM
To: Hatanaka, Akira
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] r143596 - /cfe/trunk/lib/CodeGen/TargetInfo.cpp

On Thu, Jan 5, 2012 at 4:21 PM, Hatanaka, Akira <ahatanaka at mips.com> wrote:
> Yes, we should insert padding for types that are not Struct too.
>
> Can we assume PaddingType is valid only if ABIArgInfo's TheKind is Direct? Or should other we be able to add PaddingType for other Kinds as well?

I'd say it's okay for the moment to only allow it for Direct, as long
as you document that in the code.  It should be easy enough to extend
if someone ends up needing it.

-Eli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: padding3.patch
Type: text/x-patch
Size: 7233 bytes
Desc: padding3.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120106/7b40de39/attachment.bin>