[cfe-commits] [PATCH] Suppress -Wunused-value within macros from system headers

[Chandler Carruth]

On Wed, Jan 4, 2012 at 5:05 PM, Matt Beaumont-Gay <matthewbg at google.com>wrote:

> Any objections to the new helper function in SourceManager? Also, any
> other interesting cases I should add tests for?
>

This looks pretty good to me. If you're interested in other tests,
statement expressions and comma operators maybe? It'd be good to test
TEMP_FAILURE_RETRY, the case we care about, which is a statement expression
IIRC.

Also, please test the source location before the Expr method, that method
on Expr is very expensive.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120104/7a040e80/attachment.html>