[cfe-commits] [PATCH][PR11329] Generalize -Wempty-body: warn when statement body is a empty

[Nico Weber]

Hi Dmitri,

On Wed, Jan 4, 2012 at 8:52 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> On Wed, Jan 4, 2012 at 6:47 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> Attached is a patch that implements enhancement proposed in PR11329.

I ran this patch on a chromium build. It finds many false positives,
in many different projects such as libxml, libxslt, ffmpeg, libvpx,
webrtc, hunspell, nss, nspr, dmg_fp, yasm, re2c, icu, sqlite, zlib,
native_client, and chromium itself. Since this pattern is apparently
often used intentionally I'm not sure if this is a useful warning in
practice.

Nico


ps: I can send you the build output if you want to look over it.