[cfe-commits] [PATCH] Driver: remove sole Driver-specific include from arg parsing

[nobled]

On Tue, Jan 3, 2012 at 12:02 PM, Chandler Carruth <chandlerc at google.com> wrote:
> What is your end goal here? I don't really want to see wider use of these
> APIs, they have many design warts and gotchas...
I was just moving an existing usage (for the static analyzer) out of
the generic frontend code into a plugin, and it seemed silly to depend
on libDriver when the only thing it needed was the option parsing
classes, which are already pretty cleanly separated from the rest of
the driver code. And it just made sense, them being pretty generic
utilities even if they suck right now.

>
> On Jan 3, 2012 8:59 AM, "nobled" <nobled at dreamwidth.org> wrote:
>>
>> Requires one small refactor of an API. Now everything
>> Arg-parsing-related can fit into libBasic. (Patch to migrate it there to
>> follow)
>>
>> Okay to commit?
>>
>> ---
>>  include/clang/Driver/ArgList.h      |    5 ++-
>>  lib/Driver/ArgList.cpp              |    7 ++---
>>  lib/Frontend/CompilerInvocation.cpp |   41
>> ++++++++++++++++++++--------------
>>  tools/driver/cc1as_main.cpp         |    3 +-
>>  4 files changed, 32 insertions(+), 24 deletions(-)
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>