[cfe-commits] r147385 - in /cfe/trunk: lib/AST/StmtPrinter.cpp test/SemaCXX/constexpr-printing.cpp

[Richard Smith]

On Sat, December 31, 2011 06:17, Jordy Rose wrote:
> On Dec 31, 2011, at 6:37, Richard Smith wrote:
>> +      // FIXME: Is this the best way to print wchar_t?
>> +      if (Char > 0xff) {
>> +        // char32_t values are <= 0x10ffff.
>>
>
> Can we make this an assertion?

Sounds reasonable to me. r147438.

> Or just put in the two extra lines to handle
> all 32-bit values, even though most of them are currently not valid Unicode?

Not only are they not currently Unicode, there is every indication that they
never will be.

- Richard