[cfe-commits] [PR10113][patch] Don't consider template arguments when the visibility is already explicit
chandlerc at google.com
Sun Jan 1 17:11:22 PST 2012
On Sun, Jan 1, 2012 at 5:03 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> 2012/1/1 Rafael Ávila de Espíndola <rafael.espindola at gmail.com>:
> > The attached patch fixes PR10113 by disregarding template arguments in
> > LV computation when we already have an explicit visibility.
> > This is similar to what the code already does for types. Is it OK?
> Disregarding the effect on visibility, this affects the linkage in
> ways which are clearly wrong.
This falls out of my question as well -- why doesn't merge DTRT here? Put
another way, once we encounter an explicit visibility specification for a
declaration, why would we ever merge it away? (This is distinct from
computing a visibility for a declaration from that of a set of N other
declarations, some of which use an explicit visibility spec, some of which
do not.) I feel like we should have better logic to make an explicit
visibility spec trump all else while still merging linkage.... The current
logic for merging of explicitly specified visibility makes no sense to me.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits