[cfe-commits] r147262 - in /cfe/trunk: include/clang/Driver/Options.td lib/Basic/Targets.cpp lib/Headers/immintrin.h

[Craig Topper]

On Mon, Dec 26, 2011 at 5:17 PM, Eli Friedman <eli.friedman at gmail.com>wrote:

> On Sat, Dec 24, 2011 at 9:06 PM, Craig Topper <craig.topper at gmail.com>
> wrote:
> > Modified: cfe/trunk/lib/Headers/immintrin.h
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/immintrin.h?rev=147262&r1=147261&r2=147262&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/lib/Headers/immintrin.h (original)
> > +++ cfe/trunk/lib/Headers/immintrin.h Sat Dec 24 23:06:45 2011
> > @@ -48,7 +48,7 @@
> >  #include <smmintrin.h>
> >  #endif
> >
> > -#if defined (__AES__) || defined (__PCLMUL__)
> > +#if defined (__AES__)
> >  #include <wmmintrin.h>
> >  #endif
>
> This change doesn't appear to be related to the rest of the patch; why
> are you changing this?
>

Clang doesn't define PCLMUL and the header file itself doesn't have any
PCLMUL intrinsics in it and the header file explicitly checks that AES must
be defined. So if clang did define PCLMUL and could be made to do so with
defining AES, the header would break. I'll try to work on adding the
intrinsics soon.


> -Eli
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111226/463e6d17/attachment.html>