[cfe-commits] r146619 - in /cfe/trunk: lib/Frontend/ test/ARCMT/ test/Analysis/ test/CXX/basic/basic.lookup/basic.lookup.argdep/ test/CXX/basic/basic.lookup/basic.lookup.classref/ test/CXX/basic/basic.start/basic.start.main/ test/CXX/class.access

[Chandler Carruth]

On Wed, Dec 14, 2011 at 4:38 PM, Richard Trieu <rtrieu at google.com> wrote:

> Author: rtrieu
> Date: Wed Dec 14 18:38:15 2011
> New Revision: 146619
>
> URL: http://llvm.org/viewvc/llvm-project?rev=146619&view=rev
> Log:
> Modify how the -verify flag works.  Currently, the verification string and
> diagnostic message are compared.  If either is a substring of the other,
> then
> no error is given.  This gives rise to an unexpected case:
>
>  // expect-error{{candidate function has different number of parameters}}
>
> will match the following error messages from Clang:
>
>  candidate function has different number of parameters (expected 1 but has
> 2)
>  candidate function has different number of parameters
>
> It will also match these other error messages:
>
>  candidate function
>  function has different number of parameters
>  number of parameters
>
> This patch will change so that the verification string must be a substring
> of
> the diagnostic message before accepting.  Also, all the failing tests from
> this
> change have been corrected.  Some stats from this cleanup:
>
> 87 - removed extra spaces around verification strings
> 70 - wording updates to diagnostics
> 40 - extra leading or trailing characters (typos, unmatched parens or
> quotes)
> 35 - diagnostic level was included (error:, warning:, or note:)
> 18 - flag name put in the warning (-Wprotocol)
>

Wow, that's scary. Thanks for fixing this!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111214/9d965f6a/attachment.html>