[cfe-commits] r146482 - /cfe/trunk/lib/AST/ASTContext.cpp

[Peter Cooper]

Thanks Abramo.  That makes sense.  The buildbot is indeed now failing at compilation time instead of runtime.

I'll check with the buildbot maintainers and see if we can mark those tests as ok to fail as compile time now.

Thanks,
Pete


On Dec 13, 2011, at 10:50 AM, Abramo Bagnara wrote:

> Il 13/12/2011 18:37, Peter Cooper ha scritto:
>> Hi Abramo
>> 
>> We're getting some buildbot failures on the gcc test suite since this change.  The test has a very large union in it which must be triggering your new assert.
>> 
>> Can you please have a look and see if your assert is correct on this test?
>> 
>> The test in question is gcc.c-torture/execute/991014-1.c
> 
> Yes this is definitely a true positive and assertion is correctly triggered.
> 
> I wonder what buildbot checked before as the test fails both with and
> without the assertion (before my commit you should get a failed test
> (due to miscompilation), after my commit you should get an assertion
> failure).
> 
> I guess it was used only as a crash test, right?