[cfe-commits] [patch] change libc++'s string hash function to cityhash64

[Howard Hinnant]

On Dec 9, 2011, at 9:30 PM, Howard Hinnant wrote:

> On Dec 9, 2011, at 8:55 PM, Howard Hinnant wrote:
> 
>> On Dec 9, 2011, at 8:36 PM, Chandler Carruth wrote:
>> 
>>> On Fri, Dec 9, 2011 at 5:19 PM, Howard Hinnant <hhinnant at apple.com> wrote:
>>> On Dec 9, 2011, at 8:15 PM, Chandler Carruth wrote:
>>> 
>>>> On Fri, Dec 9, 2011 at 5:14 PM, Chandler Carruth <chandlerc at google.com> wrote:
>>>> On Fri, Dec 9, 2011 at 4:50 PM, Howard Hinnant <hhinnant at apple.com> wrote:
>>>> On Dec 9, 2011, at 7:17 PM, Craig Silverstein wrote:
>>>> 
>>>>> craig
>>>>> Index: include/memory
>>>> 
>>>> I'm drawing a blank.
>>>> 
>>>> $ patch  -p0 < /Users/hhinnant/Desktop/temp.patch
>>>> patching file include/memory
>>>> patch: **** malformed patch at line 7: template <class _Tp> struct hash;
>>>> 
>>>> Anyone have a clue as to why the enclosed temp.patch is malformed?
>>>> 
>>>> Some email client somewhere has stripped leading whitespace. Unified diff patch files need a single leading space character on the context lines, and all of the leading whitespace on the patch you posted is gone.
>>>> 
>>>> I've re-attached Craig's original patch which looks to still have the correct formatting...
>>>> <cityhash.patch>
>>> 
>>> I see, thanks.  Can someone please attach Craig's second patch.  I don't want to take chances with manual editing.
>>> 
>>> Ahh, I see the second one now. Attached again here, hopefully w/ good formatting...
>>> <stringhash.patch>
>> 
>> Got it, thanks, patch successful.  Doing routine testing...
> 
> Just fyi there are some test failures I need to sort out.  At first glance I don't think it has anything to do with this patch.  But I don't want to rush it.  So I'll report back on this tomorrow.

Committed revision 146329.

Thanks to everyone who helped get this in.

Howard