[cfe-commits] [patch] change libc++'s string hash function to cityhash64

[Howard Hinnant]

On Dec 9, 2011, at 6:20 PM, Craig Silverstein wrote:

> } I think a Google entry in CREDITS.TXT would be good, and that line
> } should state that Google is the owner and contributor of the
> } CityHash algorithm.  I think that is the proper thing to do from
> } reading this line:
> 
> Perhaps so, though I looked through the existing CREDITS.TXT for both
> llvm and libc++ and didn't see anything that looks similar.
> 
> I'm guessing like you have a clear idea of what this should look like
> in your head, but I'm afraid I'm not seeing it.  For instance, I'm not
> sure if you want my name as well, or just Google.  Can you give an
> example of what you'd like the CREDITS.TXT entry to look like?  I'll
> use that as a template (or use it exactly, if all the info looks
> correct to us).
> 
> craig

Entry for your name?  Yes, definitely.

+N: Craig Silverstein
+E: csilvers at google.com
+D: Implemented Cityhash as the string hash function on 64-bit machines

Looks fine to me.

For the Google entry, I'm shooting from the hip here, but maybe something like:

N:  Google
D:  Owner and contributor of the CityHash algorithm

Just to be safe it might be a good idea to run these details back past your Google contact.

Thanks,
Howard