[cfe-commits] r146280 - in /cfe/trunk: include/clang/AST/Expr.h include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/CXX/over/over.over/p2-resolve-single-template-id.cpp test/SemaCXX/condition.cpp test/SemaCXX/warn-func-as-bo

[David Blaikie]

On Fri, Dec 9, 2011 at 1:56 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Fri, Dec 9, 2011 at 1:42 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>> +          S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
>> +          if (!ReturnType.isNull()
>>
>
> We should make Sema::isExprCallable return ReturnType.isNull() to simplify
> this pattern...
>
> I mention this as you were looking at fixing other parts isExprCallable...
>

Yeah, that bit mystified me too - the Boolean return from isExprCallable
isn't entirely clear to me - I suspect it returns true if it's overloaded
too, perhaps. (ie: if either of th eout parameters can be used - then
you're meant to test them to disambiguate)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111209/720c76eb/attachment.html>