[cfe-commits] r145697 - in /cfe/trunk: include/clang/Analysis/Analyses/FormatString.h lib/Analysis/FormatString.cpp lib/Analysis/PrintfFormatString.cpp lib/Sema/SemaChecking.cpp test/Sema/format-strings-int-typedefs.c

Hans Wennborg hans at chromium.org
Wed Dec 7 02:41:57 PST 2011


On Tue, Dec 6, 2011 at 8:02 PM, Ted Kremenek <kremenek at apple.com> wrote:
> Hi Hans,
>
> Can you make sure that 'Name' is always initialized:

Fixed.

> Also, please make getRepresentativeTypeName() and out-of-line method.  It
> does enough work that it shouldn't be in the header file.

Fixed.

>
> Other than that, it looks good to me.

Thanks, Ted. Committed in r146032.

 - Hans




More information about the cfe-commits mailing list