[cfe-commits] r145697 - in /cfe/trunk: include/clang/Analysis/Analyses/FormatString.h lib/Analysis/FormatString.cpp lib/Analysis/PrintfFormatString.cpp lib/Sema/SemaChecking.cpp test/Sema/format-strings-int-typedefs.c

[Ted Kremenek]

On Dec 5, 2011, at 5:45 AM, Hans Wennborg wrote:

> Suggesting it when it's not defined is not great, but I'm not sure
> it's actually that bad either?

I don't think most users would look kindly on a FixIt that turn a compiler warning into a compilation error.  I don't think we should unconditionally add the FixIt because of this.

If the definition of size_t is not present, the ideal solution would be to also suggest adding the #include.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111205/bbf3e710/attachment.html>