[cfe-commits] Separate semantic checking of EnumConstantDecl from the action

[Douglas Gregor]

On Nov 30, 2011, at 6:22 AM, Vassil Vassilev wrote:

> Hi,
>  The attached patch tries to split the semantic checking from the AST node creation.
>  I think it is useful one to be able to check already created AST node. Do you think that
> makes sense? Can that patch end up in clang's mainline?


I don't understand why you want to split this. Within Sema, we often combine semantic analysis with AST building so that there is just one place in the code that is responsible for making sure that the AST node is built with all of its invariants satisfied. Splitting semantic analysis from AST building makes it easier to create broken nodes that will cause problems downstream.

	- Doug