[cfe-commits] Add the support for AddressSanitizer on Darwin into the driver.

Alexander Potapenko glider at google.com
Thu Dec 1 01:28:19 PST 2011


Attached the new version, PTAL

> +  if (Args.hasArg(options::OPT_faddress_sanitizer)) {
> Please
> use Args.hasFlag(options::OPT_faddress_sanitizer, options::OPT_fno_address_sanitizer,
> false))
Done
>
> and hide the flag checking inside addAsanRTDarwinExe/etc
Then this should be something like "maybeAddAsan...", because this
function is called unconditionally and other devs may think that we
always add ASan.
I've renamed the correspoding Linux function as well.

> +const int AsanIfaceFnsSize = sizeof(AsanIfaceFns) / sizeof(char*);
> +const char *AsanIfaceFns[13] = {
> I would make these function-scope (if we end up needing them).
I've ended up using -undefined dynamic_lookup.
Indeed, if someone has an undefined symbol in this dynamic library,
let him catch this in another compiler mode.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-asan-mac.patch
Type: text/x-patch
Size: 2986 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111201/5336d08e/attachment.bin>


More information about the cfe-commits mailing list