[cfe-commits] [PATCH] Warn on function-to-bool conversion.

[Richard Trieu]

On Mon, Nov 28, 2011 at 1:38 PM, Lang Hames <lhames at gmail.com> wrote:

> This patch adds a warning for implicit conversion from functions to
> booleans.
>
> Could someone take a look and let me know if anything needs fixing or
> improving?
>
> Cheers,
> Lang.
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
Can this be changed to catch cases like this:

void foo();
if (&foo) {}

Also, have you thought about formatting the diagnostic to use the
DiagnoseImpCast() helper functions like the other implicit cast warnings?
 If you don't use it, it would be nice to add E->getSourceRange() to
underline the function name.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111128/8d758f67/attachment.html>