[cfe-commits] adding "-fasan" flag

[John McCall]

On Nov 15, 2011, at 6:40 PM, Eli Friedman wrote:
> On Tue, Nov 15, 2011 at 6:22 PM, Kostya Serebryany <kcc at google.com> wrote:
>> Hello,
>> Please review the following patch which adds -fasan (AddressSanitizer) flag
>> to clang.
>> (Mostly prepared by Chandler Carruth).
>> The LLVM part of AddressSanitizer has been submitted as r144758.
>> This patch will allow to enable AddressSanitizer from the clang command
>> line.
>> http://codereview.appspot.com/5396042
>> Coming next in separate patches:
>>   - a patch to clang driver to pass linker flags for AddressSanitizer
>> (small)
>>   - the run-time library and the tests (big)
>> Thanks,
>> --kcc
> 
> I would prefer -faddress-sanitizer over -fasan; shorter isn't really
> better here.
> 
> +  if (Args.hasFlag(options::OPT_fasan, options::OPT_fno_asan, false)) {
> +    CmdArgs.push_back("-DADDRESS_SANITIZER=1");
> +  }
> }
> 
> Why would a program need this?  Can a program that's aware of the
> address sanitizer actually do anything usefully different?  Also,
> since this define doesn't start with an underscore, it's possible this
> could break a program using the identifier ADDRESS_SANITIZER for
> something else.

It would be reasonable to make this a has_feature check.

John.