[cfe-commits] [PATCH] Fix getcontext builtin
Douglas Gregor
dgregor at apple.com
Fri Nov 11 10:24:48 PST 2011
On Nov 11, 2011, at 7:20 AM, Dimitry Andric wrote:
> On 2011-11-10 01:24, Douglas Gregor wrote:
>> On Nov 9, 2011, at 3:10 PM, Rafael EspĂndola wrote:
> ...
>>> dgregor, do these numbers have to be stable?
>> We're prefer to keep the numbers stable. Plus, that new enumerator name is certainly not following the naming convention for these enumerators.
>
> Actually, the other enumerators for typedef types use the same
> capitalization as the original types:
>
> SPECIAL_TYPE_FILE = 3,
> /// \brief C jmp_buf typedef type
> SPECIAL_TYPE_jmp_buf = 4,
> /// \brief C sigjmp_buf typedef type
> SPECIAL_TYPE_sigjmp_buf = 5,
>
> In any case, I've now put the ucontext_t-related enumerator at the end.
> Updated patch attached.
Well, it looks like those two aren't following the intended convention either. I'll fix those.
- Doug
More information about the cfe-commits
mailing list