[cfe-commits] r144379 - in /cfe/trunk: test/Misc/serialized-diags.c tools/libclang/CXLoadedDiagnostic.cpp

NAKAMURA Takumi geek4civic at gmail.com
Fri Nov 11 07:15:52 PST 2011


2011/11/12 Ted Kremenek <kremenek at apple.com>:
> I think we should instead fix CXLoadedDiagnosticSetImpl::makeString() to add a null terminator.  Your patch actually introduces a memory leak since we don't ever explicitly release these CXStrings (and expect them to get released when the CXLoadedDiagnosticSetImpl object is destroyed).

Ted, I see. Thanks to point me out.

Explanation: I took simpler patch. I should've expanded makeString() ;)

...Takumi




More information about the cfe-commits mailing list