[cfe-commits] [PATCH] Fix getcontext builtin

[Douglas Gregor]

On Nov 9, 2011, at 3:10 PM, Rafael Espíndola wrote:

> On 4 November 2011 20:04, Dimitry Andric <dimitry at andric.com> wrote:
>> On the same note as my previous post, the prototype for the built-in
>> function getcontext is incorrect, which leads to warnings like (when
>> compiling with -Wsystem-headers):
> 
> I think most of the patch is mostly OK. One part that I am not sure is:
> 
> +      /// \brief C ucontext_t typedef type
> +      SPECIAL_TYPE_ucontext_t                  = 6,
>       /// \brief Objective-C "id" redefinition type
> -      SPECIAL_TYPE_OBJC_ID_REDEFINITION        = 6,
> +      SPECIAL_TYPE_OBJC_ID_REDEFINITION        = 7,
>       /// \brief Objective-C "Class" redefinition type
> -      SPECIAL_TYPE_OBJC_CLASS_REDEFINITION     = 7,
> +      SPECIAL_TYPE_OBJC_CLASS_REDEFINITION     = 8,
>       /// \brief Objective-C "SEL" redefinition type
> -      SPECIAL_TYPE_OBJC_SEL_REDEFINITION       = 8
> +      SPECIAL_TYPE_OBJC_SEL_REDEFINITION       = 9
> 
> dgregor, do these numbers have to be stable?

We're prefer to keep the numbers stable. Plus, that new enumerator name is certainly not following the naming convention for these enumerators.

> and adding a warning to test/Misc/warning-flags.c is not OK.

Right.

	- Doug