[cfe-commits] r144058 - /cfe/trunk/lib/Sema/SemaPseudoObject.cpp

[David Blaikie]

> Revert r143972, which didn't actually compile under -Wnon-virtual-dtor.

Curious. Which version of gcc are you using? My cursor test showed
this working for a simple example in gcc 4.6

> (TIL: -Wnon-virtual-dtor is not in -Wall.)
>
> Modified:
>     cfe/trunk/lib/Sema/SemaPseudoObject.cpp
>
> Modified: cfe/trunk/lib/Sema/SemaPseudoObject.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaPseudoObject.cpp?rev=144058&r1=144057&r2=144058&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Sema/SemaPseudoObject.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaPseudoObject.cpp Mon Nov  7 19:53:17 2011
> @@ -141,6 +141,8 @@
>        : S(S), ResultIndex(PseudoObjectExpr::NoResult),
>          GenericLoc(genericLoc) {}
>
> +    virtual ~PseudoOpBuilder() {}
> +
>      /// Add a normal semantic expression.
>      void addSemanticExpr(Expr *semantic) {
>        Semantics.push_back(semantic);
> @@ -179,9 +181,6 @@
>      virtual ExprResult buildGet() = 0;
>      virtual ExprResult buildSet(Expr *, SourceLocation,
>                                  bool captureSetValueAsResult) = 0;
> -
> -  protected:
> -    ~PseudoOpBuilder() {}
>    };
>
>    /// A PseudoOpBuilder for Objective-C @properties.
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>


-- 
-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GCS d+@ s++: a-- C++++ ULS++ P L++ !E W++ N+ o? K? w(+) O? M@ V? PS+ PE@
Y+ PGP- t(+) 5 X+ R tv+ b+ DI++ D++ G+ e++ h- r y?
------END GEEK CODE BLOCK------